| commit | c862554bd846dac5c2dfc4d150b5647d7563b8d7 | |
| author | andresantoso <andresantoso@chromium.org> | |
| Fri, 10 Apr 2015 21:05:53 +0000 (10 14:05 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 10 Apr 2015 21:06:20 +0000 (10 21:06 +0000) | ||
| tree | ff849c31e0d6595646f3e7933650dbb3ae9ed074 | treesnapshot (tar.gz zip) |
| parent | c2c9bb08b9683a1313f61b64614fa8e1e2c39785 | commitdiff |
MacViews: Link mac_views_browser cleanly
Currently mac_views_browser can link successfully, but with many duplicate
definitions of global functions that are defined in both browser/ui/cocoa and
browser/ui/views.
Exclude Cocoa browser window related sources from mac_views_browser, so
that it links cleanly.
omnibox, global_error and one_click_signin grouped both Views and Cocoa
implementations together. Split them to avoid duplicate symbols.
Includes minor fixes to link the Views versions of ScreenCaptureNotificationUI
and ExternalProtocolDialog.
BUG=425229
Review URL: https://codereview.chromium.org/1076943002
Cr-Commit-Position: refs/heads/master@{#324681}
Currently mac_views_browser can link successfully, but with many duplicate
definitions of global functions that are defined in both browser/ui/cocoa and
browser/ui/views.
Exclude Cocoa browser window related sources from mac_views_browser, so
that it links cleanly.
omnibox, global_error and one_click_signin grouped both Views and Cocoa
implementations together. Split them to avoid duplicate symbols.
Includes minor fixes to link the Views versions of ScreenCaptureNotificationUI
and ExternalProtocolDialog.
BUG=425229
Review URL: https://codereview.chromium.org/1076943002
Cr-Commit-Position: refs/heads/master@{#324681}