Split out Ash dependency in app info dialog unittests
commitc7bd3ce802ecdbb5a99bb1e0116d2ccd8e3bf86f
authortapted <tapted@chromium.org>
Tue, 16 Jun 2015 02:50:44 +0000 (15 19:50 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 16 Jun 2015 02:52:24 +0000 (16 02:52 +0000)
treed7d42b7aa028f61b112702140df2d542b23b3385
parent77aab6569cad38751782993fb255ba505ce70484
Split out Ash dependency in app info dialog unittests

The app info dialog doesn't have an ash dependency on Mac, so this needs
to be isolated.

The non-Ash tests have both an Extensions and a Views dependency. The
extension system requires a BrowserThreadBundle (from content), which
was previously provided by AshTestBase. However, ViewsTestBase does not
(and shouldn't) have a content dependency. Instead, it can use the
BrowserThreadBundle provided by TestExtensionEnvironment which has some
other useful things.

Then, to satisfy the Views dependency, we still can't use ViewsTestBase
because it has its own MessageLoop that will fight with the
BrowserThreadBundle. A follow-up will introduce a ScopedViewsTestHelper
to allow the test to run on Mac, but for now just use AshTestBase.

In the AppInfo unittests, make better use of TestExtensionEnvironment to
reuse common code.

BUG=485854, 412234

Review URL: https://codereview.chromium.org/1175783003

Cr-Commit-Position: refs/heads/master@{#334533}
chrome/browser/extensions/test_extension_environment.cc
chrome/browser/extensions/test_extension_environment.h
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc [new file with mode: 0644]
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h
chrome/chrome_tests_unit.gypi