| commit | c505bf51ad167592ea00ec51abc6eaa0399e318c | |
| author | dfalcantara <dfalcantara@chromium.org> | |
| Sat, 14 Feb 2015 00:58:11 +0000 (13 16:58 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Sat, 14 Feb 2015 00:58:48 +0000 (14 00:58 +0000) | ||
| tree | 16d43080e557451d0b62306710bf8caf8e6dfee6 | treesnapshot (tar.gz zip) |
| parent | be2afae76b16db4f8c85977ec3a49ae8597a94f4 | commitdiff |
[App banners] Break apart AppBannerManager and AppBannerInfoBarDelegate
Moves a bunch of code from AppBannerManager into the new Java-side
AppBannerInfoBarDelegate. This effectively makes it so that once
an app banner is created by the AppBannerManager the AppBannerInfoBar
is on its own for managing installation and blocking of the app it's
promoting.
Main changes include getting the WebContents and Tab from the infobar()
itself rather than relying on the AppBannerManager to provide it.
Further cleanup is required on the AppBannerManager to clean up the
creation pipline.
BUG=457414
Review URL: https://codereview.chromium.org/921073002
Cr-Commit-Position: refs/heads/master@{#316345}
Moves a bunch of code from AppBannerManager into the new Java-side
AppBannerInfoBarDelegate. This effectively makes it so that once
an app banner is created by the AppBannerManager the AppBannerInfoBar
is on its own for managing installation and blocking of the app it's
promoting.
Main changes include getting the WebContents and Tab from the infobar()
itself rather than relying on the AppBannerManager to provide it.
Further cleanup is required on the AppBannerManager to clean up the
creation pipline.
BUG=457414
Review URL: https://codereview.chromium.org/921073002
Cr-Commit-Position: refs/heads/master@{#316345}
12 files changed: