Revert of Fix BrowserWindowFullScreenControllerTest.TestActivate on 10.11 (patchset...
commitc3c5de0dd06fd6169ffd59ee27096af05aec7ded
authorthakis <thakis@chromium.org>
Sat, 8 Aug 2015 22:48:32 +0000 (8 15:48 -0700)
committerCommit bot <commit-bot@chromium.org>
Sat, 8 Aug 2015 22:49:00 +0000 (8 22:49 +0000)
tree867d5b9e2108923d6688a9b4959ef6178b869f0c
parenta73119a6aacb2295d801b91d58cbe04eac3ffe63
Revert of Fix BrowserWindowFullScreenControllerTest.TestActivate on 10.11 (patchset #1 id:1 of https://codereview.chromium.org/1284443002/ )

Reason for revert:
Broke BrowserWindowControllerTest.TestFullScreenActivate on 10.6: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/5411:

../../chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm:676: Failure
Value of: IsFrontWindow([controller() createFullscreenWindow])
  Actual: false
Expected: true
[  FAILED  ] BrowserWindowControllerTest.TestFullScreenActivate, where TypeParam =  and GetParam() =  (2393 ms)

(Also see red 10.6 trybot on this CL, looks like the CQ doesn't look at that though.)

Original issue's description:
> Fix BrowserWindowFullScreenControllerTest.TestActivate on 10.11
>
> This simply moves the test into browser_tests. Because unit_tests is not
> a UI process, the WindowServer doesn’t recognize its windows and, as a
> result, doesn’t return them when asked via NSWindowList. Since NSWindowList
> is used by [NSApp orderedWindows], window ordering cannot be reliably
> checked in a non-UI process on 10.11.
>
> BUG=none
> TEST=BrowserWindowControllerTest.TestFullScreenActivate
>
> Committed: https://crrev.com/ac2c408b98a735adc9b4c0181b7475f9a268f538
> Cr-Commit-Position: refs/heads/master@{#342474}

TBR=erikchen@chromium.org,mark@chromium.org,andybons@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1285503002

Cr-Commit-Position: refs/heads/master@{#342544}
chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
chrome/browser/ui/cocoa/browser_window_utils.mm