| commit | bf330448d462fd6fd9199ad2a7b33080974c88ba | |
| author | erikchen <erikchen@chromium.org> | |
| Wed, 24 Sep 2014 21:47:04 +0000 (24 14:47 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 24 Sep 2014 21:47:44 +0000 (24 21:47 +0000) | ||
| tree | ed6fd6e80a4280b2bae04a3099f82489e511b015 | treesnapshot (tar.gz zip) |
| parent | 511a8be61b52236eb0c1ee72732a4ebe1cfd3842 | commitdiff |
Mac: Revert "Make logic for disabling OS crash catcher on OSX match comment."
This CL breaks chrome://inducebrowsercrashforrealz
I don't know exactly why the behavior is broken, but it appears that setting a
signal handler for SIGTRAP interferes with breakpad exception handling. See bug
for more details.
Original CL: https://codereview.chromium.org/329423003
Original Commit: d81d222cb0d4d83436e1723f697951deaf68fdfa
TBR=cpu@chromium.org
BUG=402337
Review URL: https://codereview.chromium.org/602793002
Cr-Commit-Position: refs/heads/master@{#296530}
This CL breaks chrome://inducebrowsercrashforrealz
I don't know exactly why the behavior is broken, but it appears that setting a
signal handler for SIGTRAP interferes with breakpad exception handling. See bug
for more details.
Original CL: https://codereview.chromium.org/329423003
Original Commit: d81d222cb0d4d83436e1723f697951deaf68fdfa
TBR=cpu@chromium.org
BUG=402337
Review URL: https://codereview.chromium.org/602793002
Cr-Commit-Position: refs/heads/master@{#296530}
| chrome/app/chrome_main_delegate.cc | diffblobblamehistory |