Enable MSVC warning for unused locals.
commitbe940e9e152e528fc567c4eeeeb5930710873f98
authorPeter Kasting <pkasting@google.com>
Thu, 20 Nov 2014 23:14:08 +0000 (20 15:14 -0800)
committerPeter Kasting <pkasting@google.com>
Thu, 20 Nov 2014 23:16:57 +0000 (20 23:16 +0000)
tree8496f9708b39b9ed106be20043e2e37d6ab58eb0
parentce6760690b52af662b5684f24dca6edc20832edf
Enable MSVC warning for unused locals.

There is seemingly a bug in the compiler where it occasionally claims a local is
unused when it isn't.  This forces a few places to either inline such locals or
mark them ALLOW_UNUSED_LOCAL.

BUG=81439
TEST=none
R=brettw@chromium.org, cpu@chromium.org, jamesr@chromium.org, rvargas@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, wolenetz@chromium.org

Review URL: https://codereview.chromium.org/731373002

Cr-Commit-Position: refs/heads/master@{#305108}
42 files changed:
ash/display/display_info.cc
ash/root_window_controller_unittest.cc
base/metrics/statistics_recorder.cc
base/security_unittest.cc
build/common.gypi
build/config/compiler/BUILD.gn
chrome/browser/content_settings/host_content_settings_map_unittest.cc
chrome/browser/enumerate_modules_model_win.cc
chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
chrome/browser/extensions/external_provider_impl.cc
chrome/browser/history/in_memory_url_index_unittest.cc
chrome/browser/process_singleton_win.cc
chrome/browser/search/hotword_service_unittest.cc
chrome/browser/search/suggestions/suggestions_source.cc
chrome/browser/ui/views/certificate_viewer_win.cc
chrome/browser/ui/views/panels/panel_frame_view.cc
chrome/browser/ui/webui/sync_internals_message_handler.cc
chrome/installer/setup/setup_main.cc
chrome/installer/util/installation_validator.cc
chrome/installer/util/installer_state_unittest.cc
cloud_print/service/win/cloud_print_service.cc
content/browser/renderer_host/render_widget_host_view_aura.cc
content/child/npapi/webplugin_delegate_impl_win.cc
content/renderer/render_font_warmup_win.cc
gpu/command_buffer/service/buffer_manager_unittest.cc
gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
media/audio/win/audio_low_latency_input_win.cc
mojo/public/cpp/system/tests/macros_unittest.cc
net/base/file_stream_context_win.cc
net/dns/host_resolver_impl.cc
net/quic/quic_unacked_packet_map_test.cc
net/socket/socks5_client_socket_unittest.cc
net/socket/socks_client_socket_unittest.cc
net/tools/dump_cache/cache_dumper.cc
ui/base/dragdrop/os_exchange_data_win_unittest.cc
ui/views/controls/menu/native_menu_win.cc
ui/views/win/hwnd_message_handler.cc
ui/wm/core/nested_accelerator_controller_unittest.cc
win8/delegate_execute/crash_server_init.cc
win8/metro_driver/chrome_app_view_ash.cc