| commit | bcc806dcb8c1c00ee37c96400a9862eb7840efc7 | |
| author | jvoung <jvoung@chromium.org> | |
| Wed, 1 Jul 2015 19:44:08 +0000 (1 12:44 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 1 Jul 2015 19:44:37 +0000 (1 19:44 +0000) | ||
| tree | f259ca62df875e9b0124e8becca1a491811a7ca7 | treesnapshot (tar.gz zip) |
| parent | f66d1ecf0cd7426393088c91f2af78ff1889bab4 | commitdiff |
Tweak PNaCl component archiver in SDK to avoid leading zeros vernum.
E.g., avoid 330242 -> 33.0242 in the rev_major/rev_minor
splitting. Instead convert that to 330242 -> 33.242. This
creates some ambiguity with 330242 vs 33242. To help a bit,
label the tar file with the full 330242 (since that doesn't
have the rev_major/minor restriction). Within the version
number we also have the chrome milestone (43, vs 44) which
would help with the 330242 (milestone 44) vs 33242
(milestone much less than 44) ambiguity.
BUG=none
Review URL: https://codereview.chromium.org/1211243015
Cr-Commit-Position: refs/heads/master@{#337097}
E.g., avoid 330242 -> 33.0242 in the rev_major/rev_minor
splitting. Instead convert that to 330242 -> 33.242. This
creates some ambiguity with 330242 vs 33242. To help a bit,
label the tar file with the full 330242 (since that doesn't
have the rev_major/minor restriction). Within the version
number we also have the chrome milestone (43, vs 44) which
would help with the 330242 (milestone 44) vs 33242
(milestone much less than 44) ambiguity.
BUG=none
Review URL: https://codereview.chromium.org/1211243015
Cr-Commit-Position: refs/heads/master@{#337097}
| native_client_sdk/src/build_tools/build_sdk.py | diffblobblamehistory | |
| native_client_sdk/src/build_tools/make_pnacl_component.sh | diffblobblamehistory |