| commit | bc82d3c46cedec68b175c9572a7de412eb0e6427 | |
| author | reillyg <reillyg@chromium.org> | |
| Mon, 29 Sep 2014 19:27:54 +0000 (29 12:27 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 29 Sep 2014 19:28:09 +0000 (29 19:28 +0000) | ||
| tree | 5d012e638adbb770f9bc5eb4bf7a60ed88b8dc2f | treesnapshot (tar.gz zip) |
| parent | e01e6de4a23e8c9e53c497346d584e7f509e59f2 | commitdiff |
Rewrite apps::SavedDevicesService as extensions::DevicePermissionsManager.
This service doesn't need any Chrome dependencies after all and so it
can move into //extensions. This will make it possible for the USB
extensions API code to directly depend on it. In the process I have
rewritten the service with a couple improvements:
* C++11 for-each loops are used instead of explicit iterators.
* The DevicePermissions object is no longer an inner class (so it can
be forward declared) and it is explicitly copied when requested so
that the ownership of data on the FILE and UI threads is clear.
BUG=
Review URL: https://codereview.chromium.org/606503002
Cr-Commit-Position: refs/heads/master@{#297230}
This service doesn't need any Chrome dependencies after all and so it
can move into //extensions. This will make it possible for the USB
extensions API code to directly depend on it. In the process I have
rewritten the service with a couple improvements:
* C++11 for-each loops are used instead of explicit iterators.
* The DevicePermissions object is no longer an inner class (so it can
be forward declared) and it is explicitly copied when requested so
that the ownership of data on the FILE and UI threads is clear.
BUG=
Review URL: https://codereview.chromium.org/606503002
Cr-Commit-Position: refs/heads/master@{#297230}
17 files changed: