| commit | bbf91324fefc8e6ec6f7068910d4d2ce63b4bf39 | |
| author | tdanderson@chromium.org <tdanderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 6 Feb 2014 09:29:39 +0000 (6 09:29 +0000) | ||
| committer | tdanderson@chromium.org <tdanderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 6 Feb 2014 09:29:39 +0000 (6 09:29 +0000) | ||
| tree | 6e4c7c142349d66687e337998862653e400e49de | treesnapshot (tar.gz zip) |
| parent | 006420c7ef35469ffeeaae5f3363f68ef2b996c5 | commitdiff |
Make the member |is_cursor_visible_| in DesktopWindowTreeHostWin static.
On Windows we can have multiple root windows and the implementation
of ::ShowCursor() is based on a counter, so making this member static
ensures that ::ShowCursor() is always called exactly once whenever the
cursor visibility state changes. This prevents an incorrectly hidden
(or incorrectly shown) cursor because the number of calls to
::ShowCursor() is no longer dependent on the number of instantiated
root windows at the time when a request to change the cursor visibility
is made.
BUG=317496
Review URL: https://codereview.chromium.org/151563004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249310 0039d316-1c4b-4281-b951-d872f2087c98
On Windows we can have multiple root windows and the implementation
of ::ShowCursor() is based on a counter, so making this member static
ensures that ::ShowCursor() is always called exactly once whenever the
cursor visibility state changes. This prevents an incorrectly hidden
(or incorrectly shown) cursor because the number of calls to
::ShowCursor() is no longer dependent on the number of instantiated
root windows at the time when a request to change the cursor visibility
is made.
BUG=317496
Review URL: https://codereview.chromium.org/151563004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249310 0039d316-1c4b-4281-b951-d872f2087c98
| ui/views/widget/desktop_aura/desktop_root_window_host_win.cc | diffblobblamehistory | |
| ui/views/widget/desktop_aura/desktop_root_window_host_win.h | diffblobblamehistory |