MacViews: Consolidate BrowserWindow's fullscreen API
commitb575385b68998c92b16a9e7e9f21a818c00eb93f
authorandresantoso <andresantoso@chromium.org>
Fri, 21 Nov 2014 23:07:56 +0000 (21 15:07 -0800)
committerCommit bot <commit-bot@chromium.org>
Fri, 21 Nov 2014 23:08:16 +0000 (21 23:08 +0000)
treea609f6b6dc332b59729c9e3cf4532e2f44cead6d
parent6c0cedb3e8b941e63c05c9591c6ee29d11dfe0a2
MacViews: Consolidate BrowserWindow's fullscreen API

"Fullscreen with Chrome" is a Mac only feature with its BrowserWindow API
guarded by #if(OSX).
I need to get BrowserView building for MacViews, so this CL refactors the API
to get rid of the ifdefs.

Started by applying Erik's patch from https://crrev.com/682873002.
Then unify the fullscreen API between Cocoa and Views:

1. Add SupportsFullscreenWithChrome() to replace the ifdefs.

2. Combine the EnterFullscreen... methods into one by adding a withChrome
   parameter to EnterFullscreen().

3. Combine AddChromeToFullscreen() and RemoveChromeToFullscreen() into
   UpdateFullscreenWithChrome().

4. Delete IsFullscreenWithoutChrome().
   It is the same as IsFullscreen() && !IsFullscreenWithChrome().

5. Rename ...WithChrome to ...WithToolbar

BUG=425229

Review URL: https://codereview.chromium.org/738933002

Cr-Commit-Position: refs/heads/master@{#305312}
24 files changed:
chrome/browser/extensions/extension_fullscreen_apitest.cc
chrome/browser/ui/browser_command_controller.cc
chrome/browser/ui/browser_command_controller_unittest.cc
chrome/browser/ui/browser_commands_mac.cc
chrome/browser/ui/browser_commands_mac.h
chrome/browser/ui/browser_window.h
chrome/browser/ui/cocoa/applescript/window_applescript.mm
chrome/browser/ui/cocoa/browser_window_cocoa.h
chrome/browser/ui/cocoa/browser_window_cocoa.mm
chrome/browser/ui/cocoa/browser_window_controller.h
chrome/browser/ui/cocoa/browser_window_controller.mm
chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
chrome/browser/ui/cocoa/view_id_util_browsertest.mm
chrome/browser/ui/extensions/application_launch_web_app.cc
chrome/browser/ui/fullscreen/fullscreen_controller.cc
chrome/browser/ui/fullscreen/fullscreen_controller.h
chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc
chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc
chrome/browser/ui/fullscreen/fullscreen_controller_state_test.h
chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc
chrome/browser/ui/views/frame/browser_view.cc
chrome/browser/ui/views/frame/browser_view.h
chrome/test/base/test_browser_window.cc
chrome/test/base/test_browser_window.h