| commit | b3adff38ce4a7a85d2ee5e08ce921f445a875f85 | |
| author | mgiuca <mgiuca@chromium.org> | |
| Mon, 11 May 2015 05:10:58 +0000 (10 22:10 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 11 May 2015 05:11:16 +0000 (11 05:11 +0000) | ||
| tree | 27ca93ff1b06d28508b2d59b4382472b68cbab65 | treesnapshot (tar.gz zip) |
| parent | c07e2cccb0d8b69e1b81fc2293ce8c7e5a2c5fb7 | commitdiff |
Re-enable WebstoreProviderTest on all platforms.
No evidence that these are no longer flaky, but we couldn't diagnose
this at the time and it's bad to keep them disabled. Re-enabling (at
least temporarily) will allow us to determine whether it is still flaky
and give us some more data points.
(Note: Ideally, these would be unit tests, not multi-process browser
tests, but there is too much multi-process logic in the code-under-test,
including the caching, the network server and URL fetching, and the JSON
decoding. Converting to a unit test requires a non-trivial refactor of
the code under test.)
BUG=246136
Review URL: https://codereview.chromium.org/1125413004
Cr-Commit-Position: refs/heads/master@{#329096}
No evidence that these are no longer flaky, but we couldn't diagnose
this at the time and it's bad to keep them disabled. Re-enabling (at
least temporarily) will allow us to determine whether it is still flaky
and give us some more data points.
(Note: Ideally, these would be unit tests, not multi-process browser
tests, but there is too much multi-process logic in the code-under-test,
including the caching, the network server and URL fetching, and the JSON
decoding. Converting to a unit test requires a non-trivial refactor of
the code under test.)
BUG=246136
Review URL: https://codereview.chromium.org/1125413004
Cr-Commit-Position: refs/heads/master@{#329096}
| chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc | diffblobblamehistory |