| commit | b1e8ea00761938ac6e4c58b42cac271d9c771059 | |
| author | oysteine <oysteine@chromium.org> | |
| Fri, 24 Apr 2015 23:41:12 +0000 (24 16:41 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 24 Apr 2015 23:41:09 +0000 (24 23:41 +0000) | ||
| tree | 4b81cf6b96a3300b77b6df71eac03c950f6bb424 | treesnapshot (tar.gz zip) |
| parent | c9f46539657b1006216a026a1b5b7a6b52857f3a | commitdiff |
Modified two extension tests to not be dependent on low-latency DOM timers
ExtensionApiTest.Bookmarks
was adding one bookmark per timer callback; changed to use an event test.
WindowOpenPanelTest.WindowOpenPanel was relying on the callback supplied to chrome.windows.create happening before the resource was actually loaded, when there's no such guarantee.
R=kalman
BUG=424661,253417,383452
Review URL: https://codereview.chromium.org/1094383005
Cr-Commit-Position: refs/heads/master@{#326933}
ExtensionApiTest.Bookmarks
was adding one bookmark per timer callback; changed to use an event test.
WindowOpenPanelTest.WindowOpenPanel was relying on the callback supplied to chrome.windows.create happening before the resource was actually loaded, when there's no such guarantee.
R=kalman
BUG=424661,253417,383452
Review URL: https://codereview.chromium.org/1094383005
Cr-Commit-Position: refs/heads/master@{#326933}
| chrome/test/data/extensions/api_test/bookmarks/manifest.json | diffblobblamehistory | |
| chrome/test/data/extensions/api_test/window_open/panel/test.js | diffblobblamehistory |