Password manager internals page service: introduction
commitb1a64b4db3cc5b4c6066ebcfbe44238b584782ce
authorvabr@chromium.org <vabr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Sun, 11 May 2014 01:48:40 +0000 (11 01:48 +0000)
committervabr@chromium.org <vabr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Sun, 11 May 2014 01:48:40 +0000 (11 01:48 +0000)
treeda09769ec17880f28a66e7048160b928ac7f494d
parent4ecd1e40bac8cd62dd603e4b6eb8d8891d529b89
Password manager internals page service: introduction

Introduce a BrowserContextKeyedService to collect logs from the PasswordManagerClient instances, and distribute them to PasswordManagerInternalsUI instances for display. The service will also ensure that nothing is logged in Incognito profiles, and that logs are flushed as soon as no one is displaying them.

Except for checking the incognito bit, the whole functionality is implemented in the LogRouter class inside the password_manager component, for easy code sharing across platforms.
The service inherits from LogRouter, and adds nothing except for leveraging the BrowserContextKeyedServiceFactory framework to keep the functionality from OTR profiles.

This CL only introduces the service, it does not put it to use (outside tests) yet.
For that there will be another CL (https://codereview.chromium.org/269513003, but WIP, not fit for (re)viewing yet).
Yet another CL deals with renaming PasswordManagerLogger to LogReceiver: https://codereview.chromium.org/264793010/

Design doc: https://docs.google.com/document/d/1ArDhTo0w-8tOPiTwqM1gG6ZGqODo8UTpXlJjjnCNK4s/edit?usp=sharing#heading=h.cqh4wuj8j4yl

BUG=347927

Review URL: https://codereview.chromium.org/262583007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269686 0039d316-1c4b-4281-b951-d872f2087c98
13 files changed:
chrome/browser/password_manager/password_manager_internals_service_unittest.cc [new file with mode: 0644]
chrome/chrome_tests_unit.gypi
components/components_tests.gyp
components/password_manager.gypi
components/password_manager/content/browser/DEPS
components/password_manager/content/browser/password_manager_internals_service_factory.cc [new file with mode: 0644]
components/password_manager/content/browser/password_manager_internals_service_factory.h [new file with mode: 0644]
components/password_manager/core/browser/DEPS
components/password_manager/core/browser/log_router.cc [new file with mode: 0644]
components/password_manager/core/browser/log_router.h [new file with mode: 0644]
components/password_manager/core/browser/log_router_unittest.cc [new file with mode: 0644]
components/password_manager/core/browser/password_manager_internals_service.cc [new file with mode: 0644]
components/password_manager/core/browser/password_manager_internals_service.h [new file with mode: 0644]