| commit | af82794391afb28318736af4bae6b3600d310484 | |
| author | brettw <brettw@chromium.org> | |
| Wed, 26 Nov 2014 19:32:07 +0000 (26 11:32 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 26 Nov 2014 19:32:42 +0000 (26 19:32 +0000) | ||
| tree | e0efb93e294468a52aac409423fbf05401dd0c54 | treesnapshot (tar.gz zip) |
| parent | e110180bcf8cce899d59bb531eb56cd4ebf0e6ed | commitdiff |
Revert of Add address3 autofill heuristics. (patchset #6 id:100001 of https://codereview.chromium.org/741493003/)
Reason for revert:
Causes AutofillOptionsWebUITest.testOpenAutofillOptions to hang.
Original issue's description:
> Add address3 autofill heuristics.
>
> We already had "address line 3" typedefs and it's supported in requestAutocomplete, but this was hot hooked up to the heuristic code.
>
> Hooking this up messed up the urban outfitters detection because of the greedy nature (matches empty labels) of the address2 detection. Adding this to address3 triggered a bad case due to bad luck (rather than design, this would also happen in the old code if there was no address3, because the unclassified address3 served to separate the address and unlabeled city). To address this problem, this patch checks for a city before matching lines with empty lines. I believe this should be a good general fix for similar patterns that we would have had with the existing "address line 2" support.
>
> Ignores duplicate form fields when one of them is hidden. Previously if there was a hidden form element and then a visible one of the same autodetected type, it would split the form (however, the reverse didn't split). It's common to have hidden sections with duplicate types in them for different locales. This unsplits llbean and continental.
>
> R=estade@chromium.org, isherman@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c7d64a4aed4c23e9a0a6d8e85a30046fa4bf77e1
TBR=isherman@chromium.org,estade@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/757333004
Cr-Commit-Position: refs/heads/master@{#305853}
Reason for revert:
Causes AutofillOptionsWebUITest.testOpenAutofillOptions to hang.
Original issue's description:
> Add address3 autofill heuristics.
>
> We already had "address line 3" typedefs and it's supported in requestAutocomplete, but this was hot hooked up to the heuristic code.
>
> Hooking this up messed up the urban outfitters detection because of the greedy nature (matches empty labels) of the address2 detection. Adding this to address3 triggered a bad case due to bad luck (rather than design, this would also happen in the old code if there was no address3, because the unclassified address3 served to separate the address and unlabeled city). To address this problem, this patch checks for a city before matching lines with empty lines. I believe this should be a good general fix for similar patterns that we would have had with the existing "address line 2" support.
>
> Ignores duplicate form fields when one of them is hidden. Previously if there was a hidden form element and then a visible one of the same autodetected type, it would split the form (however, the reverse didn't split). It's common to have hidden sections with duplicate types in them for different locales. This unsplits llbean and continental.
>
> R=estade@chromium.org, isherman@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c7d64a4aed4c23e9a0a6d8e85a30046fa4bf77e1
TBR=isherman@chromium.org,estade@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/757333004
Cr-Commit-Position: refs/heads/master@{#305853}