| commit | af2fb789440741f43adcc992bf5a13beccb3dba6 | |
| author | andresantoso <andresantoso@chromium.org> | |
| Tue, 24 Mar 2015 21:40:20 +0000 (24 14:40 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 24 Mar 2015 21:41:11 +0000 (24 21:41 +0000) | ||
| tree | 630981b0ae918aa5d59942046765350e9c2e754c | treesnapshot (tar.gz zip) |
| parent | c20184d422ea77266cc95c9ae5ce1e15a671c0ee | commitdiff |
Mac: Possible fix for Cmd-W closing window instead of a tab
This logic was simplified and made more robust with
http://crrev.com/848003006, but there is still a report that this is still a
problem.
I am suspicious of the popover detection logic. The popover could belong
to any window, and could be in the middle of fading in or out. Change the
logic to a hopefully more robust on-demand detection using
[NSApplication targetForAction:@selector(performClose:].
BUG=47134
Review URL: https://codereview.chromium.org/1025793002
Cr-Commit-Position: refs/heads/master@{#322075}
This logic was simplified and made more robust with
http://crrev.com/848003006, but there is still a report that this is still a
problem.
I am suspicious of the popover detection logic. The popover could belong
to any window, and could be in the middle of fading in or out. Change the
logic to a hopefully more robust on-demand detection using
[NSApplication targetForAction:@selector(performClose:].
BUG=47134
Review URL: https://codereview.chromium.org/1025793002
Cr-Commit-Position: refs/heads/master@{#322075}
| chrome/browser/app_controller_mac.h | diffblobblamehistory | |
| chrome/browser/app_controller_mac.mm | diffblobblamehistory |