[Extension Toolbar Redesign] Wants to act treatment, redux - left click
commitac27cf3acc998b9e19b2a677e0ffb02378860cca
authorrdevlin.cronin <rdevlin.cronin@chromium.org>
Thu, 9 Jul 2015 17:12:34 +0000 (9 10:12 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 9 Jul 2015 17:13:13 +0000 (9 17:13 +0000)
treebfdea0f229172038e55182def98d95454f8115f6
parent05d9cb5d6085995d5bfb310702ee6eedcaed980e
[Extension Toolbar Redesign] Wants to act treatment, redux - left click

The bug fully describes the new behavior for an extension that wants to act
with the toolbar redesign turned on. This patch implements the new left-click
behavior, so that an otherwise-disabled extension action's clicks forward to
the context menu. That is, right clicking on a page action that wouldn't
previously be showing opens the menu, instead of running the action. (The user
can know when this will happen based on the extension action's enabled/disabled
state, which is indicated by greyscaling the action when disabled.)

BUG=417441
TBR=sky@chromium.org (media router action)

Review URL: https://codereview.chromium.org/1216053013

Cr-Commit-Position: refs/heads/master@{#338067}
chrome/browser/ui/cocoa/extensions/browser_action_button.mm
chrome/browser/ui/extensions/extension_action_view_controller.cc
chrome/browser/ui/extensions/extension_action_view_controller.h
chrome/browser/ui/toolbar/media_router_action.cc
chrome/browser/ui/toolbar/media_router_action.h
chrome/browser/ui/toolbar/test_toolbar_action_view_controller.cc
chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h
chrome/browser/ui/toolbar/toolbar_action_view_controller.h
chrome/browser/ui/views/toolbar/toolbar_action_view.cc
chrome/browser/ui/views/toolbar/toolbar_action_view.h
chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc