Revert of Turn VariationsService::GetVariationsServerURL into instance method (patchs...
commitaaececbc843b418e0e19b78ba77bba8d7ac84a26
authorblundell <blundell@chromium.org>
Fri, 28 Aug 2015 14:22:22 +0000 (28 07:22 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 28 Aug 2015 14:23:01 +0000 (28 14:23 +0000)
treeeb4b0ba16b9eba48964ea9e38ec7c0d957258b16
parent1f62ec9869389f44af47175b541788b95de62405
Revert of Turn VariationsService::GetVariationsServerURL into instance method (patchset #2 id:20001 of https://codereview.chromium.org/1312423003/ )

Reason for revert:
It turns out that this change is actually not safe as written: g_browser_process->variations_service() returns null in non-official builds unless a default variations server URL is set on the command line. The reason the patch did not fail is because the method being called was (a) not virtual and (b) didn't use any state of the object.

Original issue's description:
> Turn VariationsService::GetVariationsServerURL into instance method
>
> This will allow for followup work that uses |client_| within that
> method.
>
> BUG=516678
> TBR=bartfab
>
> Committed: https://crrev.com/642578a171c7acee3de6b514bf2738fcb0339aac
> Cr-Commit-Position: refs/heads/master@{#346111}

TBR=asvitkine@chromium.org,bartfab@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=516678

Review URL: https://codereview.chromium.org/1320503005

Cr-Commit-Position: refs/heads/master@{#346141}
chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc
chrome/browser/metrics/variations/variations_service.cc
chrome/browser/metrics/variations/variations_service.h
chrome/browser/metrics/variations/variations_service_unittest.cc
chrome/browser/policy/policy_browsertest.cc