| commit | aa8647587cea2abd53d55bf96ade7bdf25c92883 | |
| author | primiano <primiano@chromium.org> | |
| Thu, 11 Jun 2015 12:22:51 +0000 (11 05:22 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 11 Jun 2015 12:23:30 +0000 (11 12:23 +0000) | ||
| tree | e13e29248040774319276b4ce2ac8c2ab3a6c4de | treesnapshot (tar.gz zip) |
| parent | 08e7b741d616e1f155bb6c02332fffc50b7bbaa5 | commitdiff |
[tracing] Clean up the MemoryInfra API surface (2/3)
This patch simplifies the API surface of MemoryInfra switching
attribute names from std::string to char*.
The main goal is to make the dumping fast and predictable memory-wise.
There is no point allowing the attribute names to be arbitrary strings
(read non static "quoted" char* ptrs). That has the only effect of
causing loads of copies and std::string ctors / dtors.
BUG=495628,480500
Review URL: https://codereview.chromium.org/1180733002
Cr-Commit-Position: refs/heads/master@{#333934}
This patch simplifies the API surface of MemoryInfra switching
attribute names from std::string to char*.
The main goal is to make the dumping fast and predictable memory-wise.
There is no point allowing the attribute names to be arbitrary strings
(read non static "quoted" char* ptrs). That has the only effect of
causing loads of copies and std::string ctors / dtors.
BUG=495628,480500
Review URL: https://codereview.chromium.org/1180733002
Cr-Commit-Position: refs/heads/master@{#333934}
| content/child/web_memory_allocator_dump_impl.cc | diffblobblamehistory | |
| content/child/web_memory_allocator_dump_impl.h | diffblobblamehistory |