| commit | a9e9f87c058a47db6c5709b38aae09acd56b11cc | |
| author | sammc <sammc@chromium.org> | |
| Mon, 15 Sep 2014 01:21:58 +0000 (14 18:21 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 15 Sep 2014 01:25:28 +0000 (15 01:25 +0000) | ||
| tree | 0e864a98497d3355044f8b8770cfede1c9de5269 | treesnapshot (tar.gz zip) |
| parent | 9573ca904f9d465a6be78629cc04a0aac52a36fb | commitdiff |
Mojo: Cancel WaitingCallbacks when their HandleWrappers are closed.
Currently, if a JS connector is left to be garbage collected, the handle
and the WaitingCallback both become ready to be collected at the same
time. If the handle is collected first, this results in an asynchronous
wait on a closed handle. With this change, WaitingCallback registers
itself as an observer to be notified when the handle it's watching is
closing and cancels the wait if the handle closes while the wait is in
progress.
BUG=406487
Review URL: https://codereview.chromium.org/534953002
Cr-Commit-Position: refs/heads/master@{#294775}
Currently, if a JS connector is left to be garbage collected, the handle
and the WaitingCallback both become ready to be collected at the same
time. If the handle is collected first, this results in an asynchronous
wait on a closed handle. With this change, WaitingCallback registers
itself as an observer to be notified when the handle it's watching is
closing and cancels the wait if the handle closes while the wait is in
progress.
BUG=406487
Review URL: https://codereview.chromium.org/534953002
Cr-Commit-Position: refs/heads/master@{#294775}