| commit | a4ebdc4840d05c49bfe406a10f755c5374aa1339 | |
| author | dcheng <dcheng@chromium.org> | |
| Mon, 22 Dec 2014 23:11:30 +0000 (22 15:11 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 22 Dec 2014 23:12:34 +0000 (22 23:12 +0000) | ||
| tree | 2ee5932aeaefdca7c3c2cbecf3248c1c1d59efb8 | treesnapshot (tar.gz zip) |
| parent | 40b4fa47b9288a0c262ecd3730e70bd4bb44576b | commitdiff |
Standardize usage of virtual/override/final specifiers in jingle/.
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.
BUG=417463
Review URL: https://codereview.chromium.org/822833002
Cr-Commit-Position: refs/heads/master@{#309482}
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.
BUG=417463
Review URL: https://codereview.chromium.org/822833002
Cr-Commit-Position: refs/heads/master@{#309482}