| commit | a4a08d0b3d83eae6b232636e4d07a9b0e70594ed | |
| author | vollick@chromium.org <vollick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 30 May 2013 00:18:00 +0000 (30 00:18 +0000) | ||
| committer | vollick@chromium.org <vollick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 30 May 2013 00:18:00 +0000 (30 00:18 +0000) | ||
| tree | e114801e823f885d91437929ebc349e28dc25281 | treesnapshot (tar.gz zip) |
| parent | 1764980dfa80e1f3e61e283de71ed3c3a707700c | commitdiff |
Rename ClampToMin and ClampToMax
I find these function names confusing. I have to stop and read the code each
time I try to use them to figure out what they're going to do.
Part of the confusion is that ClampToMin sets the components to the _maximum_
of the two sizes/vectors. It's also not clear from the function name which of
the two objects is acting as the 'Min'. This is mitigated by the parameter names
and local variables passed to the function, but it would be nice if the name
of the function itself made this clear.
a.ClampToLowerBound(b) makes it clear both that b is acting as the lower bound
and how and when a is going to be altered.
Other names I've considered (for ClampToMin -- the suggestions for ClampToMax
are analagous):
ClampIfSmallerThan(other)
SetComponentsToMax(other)
Union(other) (for sizes)
R=danakj,sky
BUG=None
Review URL: https://chromiumcodereview.appspot.com/14367021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203017 0039d316-1c4b-4281-b951-d872f2087c98
I find these function names confusing. I have to stop and read the code each
time I try to use them to figure out what they're going to do.
Part of the confusion is that ClampToMin sets the components to the _maximum_
of the two sizes/vectors. It's also not clear from the function name which of
the two objects is acting as the 'Min'. This is mitigated by the parameter names
and local variables passed to the function, but it would be nice if the name
of the function itself made this clear.
a.ClampToLowerBound(b) makes it clear both that b is acting as the lower bound
and how and when a is going to be altered.
Other names I've considered (for ClampToMin -- the suggestions for ClampToMax
are analagous):
ClampIfSmallerThan(other)
SetComponentsToMax(other)
Union(other) (for sizes)
R=danakj,sky
BUG=None
Review URL: https://chromiumcodereview.appspot.com/14367021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203017 0039d316-1c4b-4281-b951-d872f2087c98
30 files changed: