| commit | a274a21ae4206a89fb333d8940357b530fc18436 | |
| author | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 25 Jun 2014 12:40:58 +0000 (25 12:40 +0000) | ||
| committer | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 25 Jun 2014 12:40:58 +0000 (25 12:40 +0000) | ||
| tree | 2e287373666f5b0e175485137078dc986d788ffd | treesnapshot (tar.gz zip) |
| parent | e0cfa4c690c8b0ae74c8168efa58354f6fb40e70 | commitdiff |
Allow tests to provide a TestingFactoryFunction for NULLWhileTesting factories.
TestingProfile provides a means by which tests may provide
TestingFactoryFunctions. Previously, these were discaded by
BrowserContextDependencyManager::DoCreateBrowserContextServices if
ServiceIsNULLWhileTesting returned true. This made it impossible for
tests to provide factory functions that were in place at the very
beginning of the profile lifecycle since DoCreateBrowserContextServices
would NULL them out. With this change, DoCreateBrowserContextServices
will not override test-provided factory functions.
R=erg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/354653004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279691 0039d316-1c4b-4281-b951-d872f2087c98
TestingProfile provides a means by which tests may provide
TestingFactoryFunctions. Previously, these were discaded by
BrowserContextDependencyManager::DoCreateBrowserContextServices if
ServiceIsNULLWhileTesting returned true. This made it impossible for
tests to provide factory functions that were in place at the very
beginning of the profile lifecycle since DoCreateBrowserContextServices
would NULL them out. With this change, DoCreateBrowserContextServices
will not override test-provided factory functions.
R=erg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/354653004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279691 0039d316-1c4b-4281-b951-d872f2087c98
14 files changed: