| commit | a2497128c584e6df60ed707043d822aa00b54835 | |
| author | tdanderson@chromium.org <tdanderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 4 Jun 2014 17:09:56 +0000 (4 17:09 +0000) | ||
| committer | tdanderson@chromium.org <tdanderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 4 Jun 2014 17:09:56 +0000 (4 17:09 +0000) | ||
| tree | 5d865a85a41a6b81e3d44e29b4a107b15d02d29d | treesnapshot (tar.gz zip) |
| parent | 116da0e8d6e9028bc2cafe943e9dd24b7bf7c862 | commitdiff |
Add DCHECK to MaskedViewTargeter::GetHitTestMask() overrides
Add DCHECK_EQ(view, masked_view()) to the overrides of
MaskedViewTargeter::GetHitTestMask(). This is to ensure
the function is only called with |view| corresponding
to the view on which the targeter is installed.
This is nice to have because GetHitTestMask()
is called directly from a few places such as
overrides of View::GetHitTestMask() and (soon)
from within TabCloseButtonTargeter; see issue
377557.
BUG=377527
TEST=none
Review URL: https://codereview.chromium.org/308003019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274852 0039d316-1c4b-4281-b951-d872f2087c98
Add DCHECK_EQ(view, masked_view()) to the overrides of
MaskedViewTargeter::GetHitTestMask(). This is to ensure
the function is only called with |view| corresponding
to the view on which the targeter is installed.
This is nice to have because GetHitTestMask()
is called directly from a few places such as
overrides of View::GetHitTestMask() and (soon)
from within TabCloseButtonTargeter; see issue
377557.
BUG=377527
TEST=none
Review URL: https://codereview.chromium.org/308003019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274852 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/ui/views/tabs/tab_strip.cc | diffblobblamehistory | |
| ui/app_list/views/speech_view.cc | diffblobblamehistory | |
| ui/views/masked_view_targeter.h | diffblobblamehistory |