| commit | a141555dd2fb1866c7b7c388433aa38f82179e8c | |
| author | braveyao <braveyao@chromium.org> | |
| Mon, 4 May 2015 11:02:58 +0000 (4 04:02 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 4 May 2015 11:03:33 +0000 (4 11:03 +0000) | ||
| tree | 6679fc8b9415d8a937d259d332069a83983eecee | treesnapshot (tar.gz zip) |
| parent | ca5a45d777d9f6ca14a4e41d262268cc5139aace | commitdiff |
Make WebRtcAudioDeviceImpl::RemoveAudioRenderer not to change "playing_" flag.
Under current implementation, RemoveAudioRenderer/AddAudioRenderer can happen at any time without changing the current playout status. So it makes no sense to set 'playing_' flag to false in RemoveAudioRenderer. It's better to let only VoE manage the 'playing_' flag through Start/StopPlayout().
BUG=477434, 481532
TEST=Manual tests
R=tommi@chromium.org, henrika@chromium.org
Review URL: https://codereview.chromium.org/1113063006
Cr-Commit-Position: refs/heads/master@{#328111}
Under current implementation, RemoveAudioRenderer/AddAudioRenderer can happen at any time without changing the current playout status. So it makes no sense to set 'playing_' flag to false in RemoveAudioRenderer. It's better to let only VoE manage the 'playing_' flag through Start/StopPlayout().
BUG=477434, 481532
TEST=Manual tests
R=tommi@chromium.org, henrika@chromium.org
Review URL: https://codereview.chromium.org/1113063006
Cr-Commit-Position: refs/heads/master@{#328111}
| content/renderer/media/webrtc_audio_device_impl.cc | diffblobblamehistory |