Report dump counts as a stability metric.
commita11510d8e5175aa451f11b183a6668f581b4ec60
authorerikwright <erikwright@chromium.org>
Tue, 31 Mar 2015 22:35:58 +0000 (31 15:35 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 31 Mar 2015 22:37:12 +0000 (31 22:37 +0000)
treea9e9ce090faf53fa874cae1a6bfddb9adbb386fa
parent7bfd48ee40c9a57f02528ad76a74d2310ba268c5
Report dump counts as a stability metric.

Previously these were reported as a regular metric, against the currently running version, even though they were recorded from the previous execution, possibly from a different version.

Stability metrics are attributed to the version of the previous execution.

Also, there was an attempt to mitigate the cross-version reporting by associating each even with the version that recorded it. This is problematic for short-lived versions such as Canary.

I extracted the code, fixed the above deficiencies, wrote tests, and added functionality (also reporting the outcome of the Breakpad invocation).

BUG=460512

Review URL: https://codereview.chromium.org/1038503002

Cr-Commit-Position: refs/heads/master@{#323131}
15 files changed:
chrome/app/chrome_crash_reporter_client.cc
chrome/app/chrome_crash_reporter_client.h
chrome/browser/metrics/chrome_metrics_service_client.cc
chrome/browser/metrics/chrome_stability_metrics_provider.cc
chrome/common/chrome_constants.cc
chrome/common/chrome_constants.h
components/browser_watcher.gypi
components/browser_watcher/crash_reporting_metrics_win.cc [new file with mode: 0644]
components/browser_watcher/crash_reporting_metrics_win.h [new file with mode: 0644]
components/browser_watcher/crash_reporting_metrics_win_unittest.cc [new file with mode: 0644]
components/components_tests.gyp
components/crash/app/breakpad_win.cc
components/crash/app/crash_reporter_client.cc
components/crash/app/crash_reporter_client.h
tools/metrics/histograms/histograms.xml