| commit | a0b11455d6dcf2fd59df7b97e1c6c850b1a63bf6 | |
| author | ananta <ananta@chromium.org> | |
| Tue, 4 Nov 2014 23:23:50 +0000 (4 15:23 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 4 Nov 2014 23:24:10 +0000 (4 23:24 +0000) | ||
| tree | 88a6e59028f3bd8879611b0ab5c9169eb7f88980 | treesnapshot (tar.gz zip) |
| parent | 504d780c7e67390d85cc918a6c11617ddd36a495 | commitdiff |
For multiline text use the maximum of the string height and the line height while calculating the height of the text being displayed.
The current code in the Canvas::SizeStringFloat function uses the passed in line_height while calculating the total
height for multiline text. This works for all cases except for DirectWrite where in the text height is a touch bigger
leading to it getting clipped. Example where this breaks is in the message center notifications where the line height
is hardcoded to 18. We could fix notification views. However it seems like fixing canvas_skia would be better.
BUG=429108
Review URL: https://codereview.chromium.org/692803004
Cr-Commit-Position: refs/heads/master@{#302704}
The current code in the Canvas::SizeStringFloat function uses the passed in line_height while calculating the total
height for multiline text. This works for all cases except for DirectWrite where in the text height is a touch bigger
leading to it getting clipped. Example where this breaks is in the message center notifications where the line height
is hardcoded to 18. We could fix notification views. However it seems like fixing canvas_skia would be better.
BUG=429108
Review URL: https://codereview.chromium.org/692803004
Cr-Commit-Position: refs/heads/master@{#302704}
| ui/gfx/canvas_skia.cc | diffblobblamehistory |