| commit | a00232759e5d75b0c56d8b9e6e66b8f7c5a01ab5 | |
| author | pritam.nikam <pritam.nikam@samsung.com> | |
| Tue, 31 Mar 2015 21:28:28 +0000 (31 14:28 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 31 Mar 2015 21:29:28 +0000 (31 21:29 +0000) | ||
| tree | 88ad8cba8ef1eeb32f76013e12a79ecd125e2591 | treesnapshot (tar.gz zip) |
| parent | 6f9dd0a9c66ab98a956c0f1c42abe8efb554d34c | commitdiff |
[Password Manager] Fix to resolve DCHECK when seeing '\n' character in a saved credential username.
With present implementation the autofill suggestions get elided to fit within the screen bounds. Same (elided text "userā¤") being compared with actual suggestion values ("user\n") at the time of selecting suggestions, that apparently fails and results into browser abort with DCHECK.
With this patch we pass actual suggestion value string instead of elided text to DidSelectSuggestion() avoiding DCHECK failure.
BUG=458178
Review URL: https://codereview.chromium.org/1040083003
Cr-Commit-Position: refs/heads/master@{#323114}
With present implementation the autofill suggestions get elided to fit within the screen bounds. Same (elided text "userā¤") being compared with actual suggestion values ("user\n") at the time of selecting suggestions, that apparently fails and results into browser abort with DCHECK.
With this patch we pass actual suggestion value string instead of elided text to DidSelectSuggestion() avoiding DCHECK failure.
BUG=458178
Review URL: https://codereview.chromium.org/1040083003
Cr-Commit-Position: refs/heads/master@{#323114}
| chrome/browser/ui/autofill/autofill_popup_controller_impl.cc | diffblobblamehistory |