| commit | 9ef37b7ad6c9c44ec8f3770c2bf6c9301c93ff7c | |
| author | dglazkov@chromium.org <dglazkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 31 Jan 2014 05:11:13 +0000 (31 05:11 +0000) | ||
| committer | dglazkov@chromium.org <dglazkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 31 Jan 2014 05:11:13 +0000 (31 05:11 +0000) | ||
| tree | a57ceb771e7e04fb085b2b5d42a0325f39964f5b | treesnapshot (tar.gz zip) |
| parent | 526da9d0a89e8640b6e6d0fb4d7dfa8446bf2304 | commitdiff |
Revert 248115 "WebMediaPlayer{Android,Impl}: use RenderFrameObse..."
Broke media/adopt-node-crash.html.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&showExpectations=true&tests=media%2Fadopt-node-crash.html
> WebMediaPlayer{Android,Impl}: use RenderFrameObserver instead of ML::DestructionObserver/RenderViewObserver.
>
> RenderThreadImpl is torn down before the main thread's MessageLoop is, and some
> of WebMediaPlayerAndroid's dependencies require the render thread to still be
> alive, so move its tear-down to earlier in the process.
> This is the Android version of r240125 which fixed the same bug in
> WebMediaPlayerImpl, but forgot that WebMediaPlayerAndroid is a fork.
>
> Since RenderViewObserver is apparently out of favor nowadays, use RenderFrameObserver.
>
> BUG=338393,304967,338481
>
> Review URL: https://codereview.chromium.org/137243005
TBR=fischman@chromium.org
Review URL: https://codereview.chromium.org/136693016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248128 0039d316-1c4b-4281-b951-d872f2087c98
Broke media/adopt-node-crash.html.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&showExpectations=true&tests=media%2Fadopt-node-crash.html
> WebMediaPlayer{Android,Impl}: use RenderFrameObserver instead of ML::DestructionObserver/RenderViewObserver.
>
> RenderThreadImpl is torn down before the main thread's MessageLoop is, and some
> of WebMediaPlayerAndroid's dependencies require the render thread to still be
> alive, so move its tear-down to earlier in the process.
> This is the Android version of r240125 which fixed the same bug in
> WebMediaPlayerImpl, but forgot that WebMediaPlayerAndroid is a fork.
>
> Since RenderViewObserver is apparently out of favor nowadays, use RenderFrameObserver.
>
> BUG=338393,304967,338481
>
> Review URL: https://codereview.chromium.org/137243005
TBR=fischman@chromium.org
Review URL: https://codereview.chromium.org/136693016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248128 0039d316-1c4b-4281-b951-d872f2087c98