| commit | 9bec08811b1da383460e87ac80b3ecc46ef8ce19 | |
| author | dpolukhin@chromium.org <dpolukhin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 5 Nov 2013 06:48:01 +0000 (5 06:48 +0000) | ||
| committer | dpolukhin@chromium.org <dpolukhin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 5 Nov 2013 06:48:01 +0000 (5 06:48 +0000) | ||
| tree | 8e11d51721a2e7c2ac448bace791bfb390b6a190 | treesnapshot (tar.gz zip) |
| parent | 114c6093408c5cbb61e622eb922c808d3c4fb7c0 | commitdiff |
chrome.windows.create should return new window id in Guest mode
Some context: Chrome OS Guest mode is incognito mode and user extensions are
disabled but we have couple component extensions that work in Guest mode.
QuickOffice is one of them. It uses incognito split mode and runs in incognito
profile. CanCrossIncognito returns false if extension runs in not split mode.
Therefore include_incognito is false. But in general there is no problem
if chrome.windows.create return incognito window if extension itself already
works in incognito mode.
BUG=313789
TEST=manual
Review URL: https://codereview.chromium.org/49463006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232931 0039d316-1c4b-4281-b951-d872f2087c98
Some context: Chrome OS Guest mode is incognito mode and user extensions are
disabled but we have couple component extensions that work in Guest mode.
QuickOffice is one of them. It uses incognito split mode and runs in incognito
profile. CanCrossIncognito returns false if extension runs in not split mode.
Therefore include_incognito is false. But in general there is no problem
if chrome.windows.create return incognito window if extension itself already
works in incognito mode.
BUG=313789
TEST=manual
Review URL: https://codereview.chromium.org/49463006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232931 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/extensions/api/tabs/tabs_api.cc | diffblobblamehistory |