| commit | 9a5d78e977ed0c349ffe41fb257e8525090a864e | |
| author | yiyaoliu <yiyaoliu@chromium.org> | |
| Wed, 29 Oct 2014 13:10:46 +0000 (29 06:10 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 29 Oct 2014 13:11:03 +0000 (29 13:11 +0000) | ||
| tree | 14338fd16c54019dcb2ac25171d5101d17fd15ad | treesnapshot (tar.gz zip) |
| parent | 5647b45161456e01e6cec6ec63e96f870fe506cb | commitdiff |
Revert of Enable the bubble UI by default on Linux(not including Cros) and Win (patchset #11 id:420001 of https://codereview.chromium.org/679253003/)
Reason for revert:
The check for histogram "SessionCrashed.Bubble" is called too early that the browser creating process might not be finished. So sometimes histogram is being checked first and then being recorded, resulting in the test failure.
BUG=428235
Original issue's description:
> Enable the bubble UI by default on Linux(not including Cros) and Win.
>
> On Chrome OS, the original infobar is still shown.
>
> Removed the infobar check under test StartupBrowserCreatorTest.ProfilesLaunchedAfterCrash. This test does not run under ChromeOS, and on other platforms (Windows and non-ChromeOS Linux, the infobar is not shown any more).
>
> BUG=364670
>
> Committed: https://crrev.com/d6432657771a9fd720179d8c3dd64c8daee025c7
> Cr-Commit-Position: refs/heads/master@{#301750}
TBR=asvitkine@chromium.org,msw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364670
Review URL: https://codereview.chromium.org/684173002
Cr-Commit-Position: refs/heads/master@{#301823}
Reason for revert:
The check for histogram "SessionCrashed.Bubble" is called too early that the browser creating process might not be finished. So sometimes histogram is being checked first and then being recorded, resulting in the test failure.
BUG=428235
Original issue's description:
> Enable the bubble UI by default on Linux(not including Cros) and Win.
>
> On Chrome OS, the original infobar is still shown.
>
> Removed the infobar check under test StartupBrowserCreatorTest.ProfilesLaunchedAfterCrash. This test does not run under ChromeOS, and on other platforms (Windows and non-ChromeOS Linux, the infobar is not shown any more).
>
> BUG=364670
>
> Committed: https://crrev.com/d6432657771a9fd720179d8c3dd64c8daee025c7
> Cr-Commit-Position: refs/heads/master@{#301750}
TBR=asvitkine@chromium.org,msw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364670
Review URL: https://codereview.chromium.org/684173002
Cr-Commit-Position: refs/heads/master@{#301823}
| chrome/browser/ui/startup/startup_browser_creator_browsertest.cc | diffblobblamehistory | |
| chrome/browser/ui/views/session_crashed_bubble_view.cc | diffblobblamehistory |