| commit | 9a1800e4df575c7f7035cfbfddb84dcf879d217c | |
| author | rdevlin.cronin <rdevlin.cronin@chromium.org> | |
| Thu, 28 Aug 2014 21:06:55 +0000 (28 14:06 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 28 Aug 2014 21:08:21 +0000 (28 21:08 +0000) | ||
| tree | f2b1e94131faedfed1a17749c975e1cdc5d19697 | treesnapshot (tar.gz zip) |
| parent | db0482c7dae49d6d35530d867deb995c7ae97fb3 | commitdiff |
Make a ShowExtensionActionPopup function
More-or-less consolidate calls to show an ExtensionAction's
popup into ExtensionActionAPI. This has the happy effect of
reducing the amount of piping we have to do in the UI code
(cutting a few steps out of the Browser -> BrowserWindow ->
Toolbar -> BrowserActionsContainer -> BrowserActionView chain),
and, more importantly, lets page action command executions
happen in the BrowserActionsContainer when the redesign is
enabled.
Hopefully, this means that we can stop showing page actions
in the location bar with the switch enabled - but that's
another patch.
BUG=397259
TBR=sky@chromium.org (minor changes to test_browser_window)
Review URL: https://codereview.chromium.org/489183005
Cr-Commit-Position: refs/heads/master@{#292462}
More-or-less consolidate calls to show an ExtensionAction's
popup into ExtensionActionAPI. This has the happy effect of
reducing the amount of piping we have to do in the UI code
(cutting a few steps out of the Browser -> BrowserWindow ->
Toolbar -> BrowserActionsContainer -> BrowserActionView chain),
and, more importantly, lets page action command executions
happen in the BrowserActionsContainer when the redesign is
enabled.
Hopefully, this means that we can stop showing page actions
in the location bar with the switch enabled - but that's
another patch.
BUG=397259
TBR=sky@chromium.org (minor changes to test_browser_window)
Review URL: https://codereview.chromium.org/489183005
Cr-Commit-Position: refs/heads/master@{#292462}
31 files changed: