| commit | 985f4d610a682fb4059d0360fc4de9da45bf34d8 | |
| author | mdempsky <mdempsky@chromium.org> | |
| Mon, 30 Mar 2015 21:37:23 +0000 (30 14:37 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 30 Mar 2015 21:38:22 +0000 (30 21:38 +0000) | ||
| tree | 9371402604506c9a2c904b4f41f6ef3ab87d1ea4 | treesnapshot (tar.gz zip) |
| parent | 2c3f7251bce777a0792565c98269246bec632824 | commitdiff |
build/config: use "trim string" instead of "value" for clang revision
Clang revisions aren't always GN literals; e.g., right now it's
"233105-1", but GN's "value" conversion parses as just "233105",
silently ignoring the trailing "-1".
See also discussion on gn-dev:
https://groups.google.com/a/chromium.org/d/msg/gn-dev/hHRC1HuWBo8/drOd5dTvO5oJ
Review URL: https://codereview.chromium.org/1049453002
Cr-Commit-Position: refs/heads/master@{#322874}
Clang revisions aren't always GN literals; e.g., right now it's
"233105-1", but GN's "value" conversion parses as just "233105",
silently ignoring the trailing "-1".
See also discussion on gn-dev:
https://groups.google.com/a/chromium.org/d/msg/gn-dev/hHRC1HuWBo8/drOd5dTvO5oJ
Review URL: https://codereview.chromium.org/1049453002
Cr-Commit-Position: refs/heads/master@{#322874}
| build/config/compiler/BUILD.gn | diffblobblamehistory |