| commit | 97d6a5c0857686069de6eac94f8a41523abeaba7 | |
| author | bauerb@chromium.org <bauerb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 11 Nov 2013 23:51:24 +0000 (11 23:51 +0000) | ||
| committer | bauerb@chromium.org <bauerb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 11 Nov 2013 23:51:24 +0000 (11 23:51 +0000) | ||
| tree | 3846ce285000d1aba94a5789d79007950bbd7079 | treesnapshot (tar.gz zip) |
| parent | 58461a5121e40e6010d0b3d2d9b2b7e29a03629a | commitdiff |
Separate WindowedNotificationObserver creation from waiting in extension_service_unittest.cc.
Waiting on a WindowedNotificationObserver directly after creation (i.e. WindowedNotificationObserver().Wait()) makes it more likely to break if the notification we're waiting for is sent before construction.
BUG=none
Review URL: https://codereview.chromium.org/37103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234323 0039d316-1c4b-4281-b951-d872f2087c98
Waiting on a WindowedNotificationObserver directly after creation (i.e. WindowedNotificationObserver().Wait()) makes it more likely to break if the notification we're waiting for is sent before construction.
BUG=none
Review URL: https://codereview.chromium.org/37103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234323 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/extensions/extension_service_unittest.cc | diffblobblamehistory |