| commit | 96fa4fb9f7de519ecf7e0067118afe80bec2b2b9 | |
| author | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Sun, 24 Feb 2013 21:58:55 +0000 (24 21:58 +0000) | ||
| committer | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Sun, 24 Feb 2013 21:58:55 +0000 (24 21:58 +0000) | ||
| tree | b3b4c00146bd8e829fd6660abc576ea082e3da0c | treesnapshot (tar.gz zip) |
| parent | c3088cbb5cbd5c91b6c5602750ec327ff7963862 | commitdiff |
cros: Move JobRestartRequest and GetOTRCommandLine out of login_utils.
- Move them out of login_utils for using with app mode;
- Move JobRestarRequest's ensure local state committed task from FILE thread
to local state task runner thread because that's where local state writing
is happening now;
- Make JobRestartRequest a weak ptr based instead of ref count because
we now have PostTaskAndReply and don't have to keep it alive while
waiting for its touch base task to run on local state writing thread;
- Splitting GetOffTheRecordCommand's generic part into a DeriveCommandLine
function so that we could reuse it for creating app mode command line;
BUG=173803
TEST=none.
R=nkostylev@chromium.org,zelidrag@chromium.org
TBR=sky@chromium.org
for gyp and browser_navigator_browsertest_chromeos.cc change
Review URL: https://chromiumcodereview.appspot.com/12335054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184357 0039d316-1c4b-4281-b951-d872f2087c98
- Move them out of login_utils for using with app mode;
- Move JobRestarRequest's ensure local state committed task from FILE thread
to local state task runner thread because that's where local state writing
is happening now;
- Make JobRestartRequest a weak ptr based instead of ref count because
we now have PostTaskAndReply and don't have to keep it alive while
waiting for its touch base task to run on local state writing thread;
- Splitting GetOffTheRecordCommand's generic part into a DeriveCommandLine
function so that we could reuse it for creating app mode command line;
BUG=173803
TEST=none.
R=nkostylev@chromium.org,zelidrag@chromium.org
TBR=sky@chromium.org
for gyp and browser_navigator_browsertest_chromeos.cc change
Review URL: https://chromiumcodereview.appspot.com/12335054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184357 0039d316-1c4b-4281-b951-d872f2087c98