Revert of Reland: Introduce sys_sigprocmask and sys_sigaction. (patchset #5 id:160001...
commit958459af4fb9f922a22ab0d1fc32145f237793d4
authormagjed <magjed@chromium.org>
Wed, 22 Apr 2015 13:03:58 +0000 (22 06:03 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 22 Apr 2015 13:04:06 +0000 (22 13:04 +0000)
treebced854c2c0eb3c0011b4238b82ec008147cea18
parent492f2be21ec3c2911faa6ed5b0ff6145c4bd60b4
Revert of Reland: Introduce sys_sigprocmask and sys_sigaction. (patchset #5 id:160001 of https://codereview.c… (patchset #4 id:80001 of https://codereview.chromium.org/1092153005/)

Reason for revert:
Causing Linux Tests to fail:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/41533

sandbox_linux_unittests Trap.SigSysAction failed 14
failures:
Syscall.SyntheticSixArgs
SandboxBPF.PthreadEquality
SandboxBPF.Pread64
SandboxBPF.UnsafeTrapWithErrno
SandboxBPF.ForwardSyscall
SandboxBPF.BasicBlacklistWithSigsys
SandboxBPF.SigBus
Trap.SigSysAction
SandboxBPF.VerboseAPITesting
ParameterRestrictions.sched_getparam_allowed
SandboxBPF.UnsafeTrapWithCond

[ RUN      ] SandboxBPF.VerboseAPITesting
../../sandbox/linux/tests/unit_tests.cc:234: Failure
Value of: subprocess_terminated_normally
  Actual: false
Expected: true

Original issue's description:
> Reland: Introduce sys_sigprocmask and sys_sigaction. (patchset #5 id:160001 of https://codereview.chromium.org/1077143002/)
>
> This CL is relanding the CL https://codereview.chromium.org/1077143002/,
> which was reverted due to false alarm of the memory sanitizer.
> Because the memory sanitizer does not know about direct kernel syscall
> does, so it warns the arguments of the signal handler, unexpectedly.
> This CL adds the msan unpoisoning to the arguemtns, so that the memory
> sanitizer should understand it.
>
> TEST=Ran sandbox_linux_unittests with msan=1. Ran bots.
> BUG=358465
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm
>
> Committed: https://crrev.com/c1c944e1ee0b100c9717084b50bdd697c6b308d2
> Cr-Commit-Position: refs/heads/master@{#326270}

TBR=mdempsky@chromium.org,hidehiko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=358465,479705

Review URL: https://codereview.chromium.org/1102543003

Cr-Commit-Position: refs/heads/master@{#326278}
21 files changed:
sandbox/linux/BUILD.gn
sandbox/linux/sandbox_linux.gypi
sandbox/linux/sandbox_linux_test_sources.gypi
sandbox/linux/seccomp-bpf/die.cc
sandbox/linux/seccomp-bpf/syscall.h
sandbox/linux/seccomp-bpf/trap.cc
sandbox/linux/seccomp-bpf/trap.h
sandbox/linux/seccomp-bpf/trap_unittest.cc [deleted file]
sandbox/linux/services/credentials.cc
sandbox/linux/services/syscall_wrappers.cc
sandbox/linux/services/syscall_wrappers.h
sandbox/linux/services/syscall_wrappers_unittest.cc
sandbox/linux/system_headers/android_arm64_ucontext.h [moved from sandbox/linux/system_headers/arm64_linux_ucontext.h with 78% similarity]
sandbox/linux/system_headers/android_arm_ucontext.h [new file with mode: 0644]
sandbox/linux/system_headers/android_i386_ucontext.h [moved from sandbox/linux/system_headers/i386_linux_ucontext.h with 82% similarity]
sandbox/linux/system_headers/android_mips_ucontext.h [moved from sandbox/linux/system_headers/mips_linux_ucontext.h with 86% similarity]
sandbox/linux/system_headers/android_ucontext.h [new file with mode: 0644]
sandbox/linux/system_headers/android_x86_64_ucontext.h [moved from sandbox/linux/system_headers/x86_64_linux_ucontext.h with 89% similarity]
sandbox/linux/system_headers/arm_linux_ucontext.h [deleted file]
sandbox/linux/system_headers/linux_signal.h [deleted file]
sandbox/linux/system_headers/linux_ucontext.h [deleted file]