| commit | 9573d4d33bf81518dd38c732bd18bfb8851bb89a | |
| author | falken <falken@chromium.org> | |
| Wed, 15 Apr 2015 16:49:39 +0000 (15 09:49 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 15 Apr 2015 16:50:08 +0000 (15 16:50 +0000) | ||
| tree | 8c57c651e265ad14eef64928fccf20342b3777fd | treesnapshot (tar.gz zip) |
| parent | ece9b5e4d3e45d874d893f8422be0796c26bb702 | commitdiff |
Service Worker: Use more specific errors when StartWorker fails
UMA shows StartWorker fails more than expected, but most errors are just
the generic START_WORKER_FAILED. Use a more specific error when appropriate.
This has some user-visible behavior change in the error message that register()
rejects with. For example, a syntax error used to fail with "ServiceWorker failed
to install"; now it fails with "ServiceWorker script evaluation failed".
A Blink layout test is added for error messages, which didn't have test
coverage previously.
BUG=448003
TEST=https://codereview.chromium.org/1058323004
Review URL: https://codereview.chromium.org/1063823005
Cr-Commit-Position: refs/heads/master@{#325261}
UMA shows StartWorker fails more than expected, but most errors are just
the generic START_WORKER_FAILED. Use a more specific error when appropriate.
This has some user-visible behavior change in the error message that register()
rejects with. For example, a syntax error used to fail with "ServiceWorker failed
to install"; now it fails with "ServiceWorker script evaluation failed".
A Blink layout test is added for error messages, which didn't have test
coverage previously.
BUG=448003
TEST=https://codereview.chromium.org/1058323004
Review URL: https://codereview.chromium.org/1063823005
Cr-Commit-Position: refs/heads/master@{#325261}
15 files changed: