| commit | 94a2cc2c77b73aaaceae5de709c6b453f8fe2c0e | |
| author | brettw <brettw@chromium.org> | |
| Wed, 1 Jul 2015 19:26:54 +0000 (1 12:26 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 1 Jul 2015 19:28:35 +0000 (1 19:28 +0000) | ||
| tree | 9326be0be8d8cd7813115464194f0182670e8f3c | treesnapshot (tar.gz zip) |
| parent | d3cb15365f7cca8be2d794be25be88f6a72771a4 | commitdiff |
Fix some case-insensitive cases for StartsWith.
This is not all callers so the old function is not deleted. Most calls are replaced with either StartsWith with the enum, or StartsWith(base::i18n::ToLower(...) for cases that need truely-internationalized case comparison (or when I wasn't sure).
The most interesting case is chrome/installer/util which can't depend on base/i18n and it wants Unicode case-insensitive compares. I replaced these with a call to the Win32 function CompareString
Add a missing protobuf dependency in components/storage_monitor that a try run turned up.
In a few cases there is some related cleanup when I touched code: SplitString calls in experiment_labels.cc (which I've been doing patches to update), for loop in gcapi_omaha_experiment.cc,
In some cases, a ToLower call was pulled out of a loop as in autofill_agent.cc. From this file I also removed a redundant comparison since the code checked it if was equal or a prefix, and a prefix returns true if it's equal.
BUG=506255
Review URL: https://codereview.chromium.org/1220653002
Cr-Commit-Position: refs/heads/master@{#337093}
This is not all callers so the old function is not deleted. Most calls are replaced with either StartsWith with the enum, or StartsWith(base::i18n::ToLower(...) for cases that need truely-internationalized case comparison (or when I wasn't sure).
The most interesting case is chrome/installer/util which can't depend on base/i18n and it wants Unicode case-insensitive compares. I replaced these with a call to the Win32 function CompareString
Add a missing protobuf dependency in components/storage_monitor that a try run turned up.
In a few cases there is some related cleanup when I touched code: SplitString calls in experiment_labels.cc (which I've been doing patches to update), for loop in gcapi_omaha_experiment.cc,
In some cases, a ToLower call was pulled out of a loop as in autofill_agent.cc. From this file I also removed a redundant comparison since the code checked it if was equal or a prefix, and a prefix returns true if it's equal.
BUG=506255
Review URL: https://codereview.chromium.org/1220653002
Cr-Commit-Position: refs/heads/master@{#337093}
30 files changed: