| commit | 93773d08322990032231aa26c4eba4f02014de99 | |
| author | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 26 Aug 2013 18:36:46 +0000 (26 18:36 +0000) | ||
| committer | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 26 Aug 2013 18:36:46 +0000 (26 18:36 +0000) | ||
| tree | 5d46df66bf07abc8611956aa179c8cc172a44161 | treesnapshot (tar.gz zip) |
| parent | c9ba1716df1c04112a2a4a7de8f9b8a0b0e7c60b | commitdiff |
Stop menus from being double shown.
When the account chooser or any detail section is clicked while a menu is
already showing from a previous click, the showing menu should be hidden rather
than quickly closed and reshown. This is accomplished by changing the controls
showing the menus to MenuButtons, which Just Workâ˘.
This patch also modifies views::MenuController to better handle showing a menu
under the mouse cursor and wrangles some constants. Releasing the mouse on top
of a menu quickly after showing should now be ignored (based on some simple
heuristics).
R=estade@chromium.org,sadrul@chromium.org,sky@chromium.org
BUG=259553
TEST=menu hides when clicking on opening button
Review URL: https://chromiumcodereview.appspot.com/19272008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219567 0039d316-1c4b-4281-b951-d872f2087c98
When the account chooser or any detail section is clicked while a menu is
already showing from a previous click, the showing menu should be hidden rather
than quickly closed and reshown. This is accomplished by changing the controls
showing the menus to MenuButtons, which Just Workâ˘.
This patch also modifies views::MenuController to better handle showing a menu
under the mouse cursor and wrangles some constants. Releasing the mouse on top
of a menu quickly after showing should now be ignored (based on some simple
heuristics).
R=estade@chromium.org,sadrul@chromium.org,sky@chromium.org
BUG=259553
TEST=menu hides when clicking on opening button
Review URL: https://chromiumcodereview.appspot.com/19272008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219567 0039d316-1c4b-4281-b951-d872f2087c98
12 files changed: