| commit | 8fffbe2891fe353a7c4c0ecf963351ff7f40bd68 | |
| author | primiano <primiano@chromium.org> | |
| Thu, 11 Jun 2015 17:52:56 +0000 (11 10:52 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 11 Jun 2015 17:53:17 +0000 (11 17:53 +0000) | ||
| tree | 8e1608a134b17e5201f27ef27649e33124eb0cd0 | treesnapshot (tar.gz zip) |
| parent | ba339d74bf4d1d670304a9e97aa258bd3b03ac95 | commitdiff |
[tracing] Simplify the MemoryInfra API (final stage)
Drop the use of std::string as attributes name and just use
const char*. Rationale: after crrev.com/1173793003, which
refactored TracedValue basing that on pickles, there is a
huge performance benefit in keeping just the pointers and
avoid copying string over.
This is simplifying the architecture of MemoryInfra classes
in base and fixing the tests.
Also, this re-enables and fixes the web_process_memory_dump_impl_unittest
disabled in crrev.com/1175293002
BUG=495628
Review URL: https://codereview.chromium.org/1179813002
Cr-Commit-Position: refs/heads/master@{#333983}
Drop the use of std::string as attributes name and just use
const char*. Rationale: after crrev.com/1173793003, which
refactored TracedValue basing that on pickles, there is a
huge performance benefit in keeping just the pointers and
avoid copying string over.
This is simplifying the architecture of MemoryInfra classes
in base and fixing the tests.
Also, this re-enables and fixes the web_process_memory_dump_impl_unittest
disabled in crrev.com/1175293002
BUG=495628
Review URL: https://codereview.chromium.org/1179813002
Cr-Commit-Position: refs/heads/master@{#333983}