| commit | 8b3d14e7dcc7a96509383970817a7e394e20c2c3 | |
| author | tyoshino@chromium.org <tyoshino@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 13 Feb 2014 14:24:28 +0000 (13 14:24 +0000) | ||
| committer | tyoshino@chromium.org <tyoshino@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 13 Feb 2014 14:24:28 +0000 (13 14:24 +0000) | ||
| tree | acfb1319ca36afbe4fdf6b27af43920e08c15f66 | treesnapshot (tar.gz zip) |
| parent | b5a769958cbfcb76e1aaece168010ebd741ab350 | commitdiff |
Rename closing_* in WebSocketChannel to received_close_* and do some refactoring
- Variable renaming: they should be prefixed with received_ so that
reviewer can understand that they store values received from the
server
- HandleFrame() is just a part of ProcessFrame(). I want them to have
names from which we can see that
- Factor out the switch-clause in HandleFrame building a frame type
string as the method is very long
BUG=none
Review URL: https://codereview.chromium.org/131333010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250983 0039d316-1c4b-4281-b951-d872f2087c98
- Variable renaming: they should be prefixed with received_ so that
reviewer can understand that they store values received from the
server
- HandleFrame() is just a part of ProcessFrame(). I want them to have
names from which we can see that
- Factor out the switch-clause in HandleFrame building a frame type
string as the method is very long
BUG=none
Review URL: https://codereview.chromium.org/131333010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250983 0039d316-1c4b-4281-b951-d872f2087c98
| net/websockets/websocket_channel.cc | diffblobblamehistory | |
| net/websockets/websocket_channel.h | diffblobblamehistory |