| commit | 89cda3776ecc975213ac4b626845deea417f977f | |
| author | jvoung <jvoung@chromium.org> | |
| Wed, 10 Jun 2015 18:59:07 +0000 (10 11:59 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 10 Jun 2015 18:59:54 +0000 (10 18:59 +0000) | ||
| tree | 3e3889d205a7fa7224d20081c1450bf1c6f97ea0 | treesnapshot (tar.gz zip) |
| parent | 5ee458982c5706abf29f456b4383aea413766cea | commitdiff |
Add a Subzero variant of Chrome PNaCl error handling test.
Make sure that subzero can also handle various pexes with a
bad header. Test with a tiny fake .pexe (already had
that test case) and a larger realistic nonfinalized pexe.
The nonfinalized pexe requires streaming multiple chunks
and so is able to tickle an error-reporting race condition
(use-after-free) + possible deadlock. I tried it on subzero
from last week and was able to tickle the crash.
It should no longer tickle that bug this week unless
there's a regression.
The tiny version runs pretty quickly, but otherwise had
not been crashing before. It merely returned an imprecise
error message ("Some error occurred"), which should
now be fixed too.
BUG= https://code.google.com/p/nativeclient/issues/detail?id=4163
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng
Review URL: https://codereview.chromium.org/1157213005
Cr-Commit-Position: refs/heads/master@{#333769}
Make sure that subzero can also handle various pexes with a
bad header. Test with a tiny fake .pexe (already had
that test case) and a larger realistic nonfinalized pexe.
The nonfinalized pexe requires streaming multiple chunks
and so is able to tickle an error-reporting race condition
(use-after-free) + possible deadlock. I tried it on subzero
from last week and was able to tickle the crash.
It should no longer tickle that bug this week unless
there's a regression.
The tiny version runs pretty quickly, but otherwise had
not been crashing before. It merely returned an imprecise
error message ("Some error occurred"), which should
now be fixed too.
BUG= https://code.google.com/p/nativeclient/issues/detail?id=4163
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng
Review URL: https://codereview.chromium.org/1157213005
Cr-Commit-Position: refs/heads/master@{#333769}