| commit | 89a280795dfc11b6fa3139f5760aae614399358e | |
| author | vabr <vabr@chromium.org> | |
| Mon, 1 Sep 2014 17:02:05 +0000 (1 10:02 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 1 Sep 2014 17:05:43 +0000 (1 17:05 +0000) | ||
| tree | fc8d0b9ee70e90a94e855f48d36b3bf57b05e429 | treesnapshot (tar.gz zip) |
| parent | f99948e895b913e52400d5061e3d528db05bed2c | commitdiff |
[Password Manager] Restrict IsTheHotNewBubbleUIEnabled to Aura and Mac
ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled needs to return false on Android, because there is no bubble for Android.
Unintentionally, I (vabr) misinformed dconnelly in https://codereview.chromium.org/444603003/diff/20001/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode357 that IsTheHotNewBubbleUIEnabled is not compiled on Android at all, whereas the truth is, it is only not compiled for Androd WebView.
As a consequence, IsTheHotNewBubbleUIEnabled started to return possibly true on Android after https://codereview.chromium.org/505123002 landed, causing a crash on the bots.
BUG=328847,409622
Review URL: https://codereview.chromium.org/529743002
Cr-Commit-Position: refs/heads/master@{#292884}
ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled needs to return false on Android, because there is no bubble for Android.
Unintentionally, I (vabr) misinformed dconnelly in https://codereview.chromium.org/444603003/diff/20001/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode357 that IsTheHotNewBubbleUIEnabled is not compiled on Android at all, whereas the truth is, it is only not compiled for Androd WebView.
As a consequence, IsTheHotNewBubbleUIEnabled started to return possibly true on Android after https://codereview.chromium.org/505123002 landed, causing a crash on the bots.
BUG=328847,409622
Review URL: https://codereview.chromium.org/529743002
Cr-Commit-Position: refs/heads/master@{#292884}
| chrome/browser/password_manager/chrome_password_manager_client.cc | diffblobblamehistory |