| commit | 893dadc6e82a64c8135b6f4852ee0960ea62e4a5 | |
| author | erikchen <erikchen@chromium.org> | |
| Thu, 18 Jun 2015 21:48:33 +0000 (18 14:48 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 18 Jun 2015 21:49:01 +0000 (18 21:49 +0000) | ||
| tree | 9fc20294e440892646025b431e3d6f2f4f42b1f5 | treesnapshot (tar.gz zip) |
| parent | fb47c8f3ddbd1a412a18826c700d6526b345bb4e | commitdiff |
Remove unused locking functionality from base::SharedMemory.
The only existing consumers of the locking functionality were two unit tests for
SharedMemory.
The first unit test only tested the locking functionality across threads, so I
removed the test.
The second unit test was intended to test cross-process functionality of
base::SharedMemory, and used the locking functionality as a synchronization
method between processes. I rewrote the test to actually test Shared Memory
functionality, as the original test only tested synchronization between
processes, and would have succeeded even if Shared Memory didn't work. I
replaced the synchronization with compare and swap operations.
BUG=466437, 345734
Review URL: https://codereview.chromium.org/1167863002
Cr-Commit-Position: refs/heads/master@{#335135}
The only existing consumers of the locking functionality were two unit tests for
SharedMemory.
The first unit test only tested the locking functionality across threads, so I
removed the test.
The second unit test was intended to test cross-process functionality of
base::SharedMemory, and used the locking functionality as a synchronization
method between processes. I rewrote the test to actually test Shared Memory
functionality, as the original test only tested synchronization between
processes, and would have succeeded even if Shared Memory didn't work. I
replaced the synchronization with compare and swap operations.
BUG=466437, 345734
Review URL: https://codereview.chromium.org/1167863002
Cr-Commit-Position: refs/heads/master@{#335135}