| commit | 8742173c5adfab0005e9eb8f3abfd14dcf4bbf62 | |
| author | Nico Weber <thakis@chromium.org> | |
| Sat, 9 May 2015 04:10:41 +0000 (8 21:10 -0700) | ||
| committer | Nico Weber <thakis@chromium.org> | |
| Sat, 9 May 2015 04:11:38 +0000 (9 04:11 +0000) | ||
| tree | b2931aeba94e81b716274564dd97b64b34a6fb5c | treesnapshot (tar.gz zip) |
| parent | 78cca4dfe72ce133f378987e57c87921afd1f0e5 | commitdiff |
plugin: Don't warn on copy constructors on dllexported classes.
In general, implicit constructors are generated on demand. But
in the Windows component build, dllexport causes instantiation of
the copy constructor which means that this fires on many more
classes. For now, suppress this on dllexported classes.
(This does mean that windows component builds will not emit this
warning in some cases where it is emitted in other configs, but
that's the better tradeoff at this point).
BUG=483986,467288
R=hans@chromium.org
Review URL: https://codereview.chromium.org/1129843005
Cr-Commit-Position: refs/heads/master@{#329036}
In general, implicit constructors are generated on demand. But
in the Windows component build, dllexport causes instantiation of
the copy constructor which means that this fires on many more
classes. For now, suppress this on dllexported classes.
(This does mean that windows component builds will not emit this
warning in some cases where it is emitted in other configs, but
that's the better tradeoff at this point).
BUG=483986,467288
R=hans@chromium.org
Review URL: https://codereview.chromium.org/1129843005
Cr-Commit-Position: refs/heads/master@{#329036}
| tools/clang/plugins/FindBadConstructsConsumer.cpp | diffblobblamehistory |