| commit | 8413aadee300359e05e1592e75364e40dcc21b6a | |
| author | tdanderson@chromium.org <tdanderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 2 Jun 2014 23:22:45 +0000 (2 23:22 +0000) | ||
| committer | tdanderson@chromium.org <tdanderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 2 Jun 2014 23:22:45 +0000 (2 23:22 +0000) | ||
| tree | ed01117ecd3273e3e69f42399625a2200e427a37 | treesnapshot (tar.gz zip) |
| parent | 674b6567e2fa738e2db2e5174d3ff8ff96740c7b | commitdiff |
Remove overrides of HitTestRect() which just return false
Some overrides of View::HitTestRect() just return
false in order to force event-targeting to fail for
that view type and its descendants. Because this
logic is unrelated to hit-testing against a rectangular
region, remove these overrides and instead override
View::CanProcessEventsWithinSubtree() to just return
false.
The relevant classes are:
ProfileImageView
ShelfButton::BarView
ShelfButton::IconView
PasswordRow
BoundedLabel
Label (and Link as a result)
BUG=374303
TEST=none
Review URL: https://codereview.chromium.org/287193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274366 0039d316-1c4b-4281-b951-d872f2087c98
Some overrides of View::HitTestRect() just return
false in order to force event-targeting to fail for
that view type and its descendants. Because this
logic is unrelated to hit-testing against a rectangular
region, remove these overrides and instead override
View::CanProcessEventsWithinSubtree() to just return
false.
The relevant classes are:
ProfileImageView
ShelfButton::BarView
ShelfButton::IconView
PasswordRow
BoundedLabel
Label (and Link as a result)
BUG=374303
TEST=none
Review URL: https://codereview.chromium.org/287193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274366 0039d316-1c4b-4281-b951-d872f2087c98