| commit | 83efcca84ad02b82422daf9e534960ccbce88e4f | |
| author | mtomasz@chromium.org <mtomasz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 21 May 2014 20:17:40 +0000 (21 20:17 +0000) | ||
| committer | mtomasz@chromium.org <mtomasz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 21 May 2014 20:17:40 +0000 (21 20:17 +0000) | ||
| tree | d96fb92e115021e83bd74a16814543909a31f7f0 | treesnapshot (tar.gz zip) |
| parent | f52bc90edbf5e548338a9b9f05a7c11f4be843cf | commitdiff |
[fsp] Do not crash on an invalid modification time.
Before, if a modification time was InvalidDate, then it caused a crash on
a DCHECK converting a string date to base::Time.
Providers may return an incorrect date, and we shouldn't crash. This patch
resolves this issue by removing the DCHECK and passing the invalid date
to fileapi.
TEST=unit_test: *FileSystemProvider*GetMetadata*
BUG=248427
Review URL: https://codereview.chromium.org/295933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271959 0039d316-1c4b-4281-b951-d872f2087c98
Before, if a modification time was InvalidDate, then it caused a crash on
a DCHECK converting a string date to base::Time.
Providers may return an incorrect date, and we shouldn't crash. This patch
resolves this issue by removing the DCHECK and passing the invalid date
to fileapi.
TEST=unit_test: *FileSystemProvider*GetMetadata*
BUG=248427
Review URL: https://codereview.chromium.org/295933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271959 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc | diffblobblamehistory | |
| chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js | diffblobblamehistory |