| commit | 82c6af625500a7bfdcf9f619c4e5702fa12f2b40 | |
| author | wjmaclean <wjmaclean@chromium.org> | |
| Fri, 31 Oct 2014 22:00:13 +0000 (31 15:00 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 31 Oct 2014 22:01:16 +0000 (31 22:01 +0000) | ||
| tree | a3321c2ace740402b593822744812becbf63ddc7 | treesnapshot (tar.gz zip) |
| parent | e0dbdbe3aa7dce4dda9e9acb20325d8476003fa8 | commitdiff |
Revert of WebView Guest should use ZOOM_MODE_ISOLATED. (patchset #2 id:100001 of https://codereview.chromium.org/645153002/)
Reason for revert:
This CL seems to be at the root of several other issues, including https://code.google.com/p/chromium/issues/detail?id=429004.
In particular, it seems to be allowing re-entrancy into ZoomController that was unexpected due to the timing with which OnGuestReady() is called.
Original issue's description:
> WebView Guest should use ZOOM_MODE_ISOLATED.
>
> In order that changes to zoom levels in a WebView Guest don't affect
> the embedder, set the WebView Guest's WebContents to use
> ZOOM_MODE_ISOLATED.
>
> BUG=418605
>
> Committed: https://crrev.com/f71a5dc79473cc74990d1e288c66ac282c2926a1
> Cr-Commit-Position: refs/heads/master@{#299493}
TBR=fsamuel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418605
Review URL: https://codereview.chromium.org/690373002
Cr-Commit-Position: refs/heads/master@{#302332}
Reason for revert:
This CL seems to be at the root of several other issues, including https://code.google.com/p/chromium/issues/detail?id=429004.
In particular, it seems to be allowing re-entrancy into ZoomController that was unexpected due to the timing with which OnGuestReady() is called.
Original issue's description:
> WebView Guest should use ZOOM_MODE_ISOLATED.
>
> In order that changes to zoom levels in a WebView Guest don't affect
> the embedder, set the WebView Guest's WebContents to use
> ZOOM_MODE_ISOLATED.
>
> BUG=418605
>
> Committed: https://crrev.com/f71a5dc79473cc74990d1e288c66ac282c2926a1
> Cr-Commit-Position: refs/heads/master@{#299493}
TBR=fsamuel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418605
Review URL: https://codereview.chromium.org/690373002
Cr-Commit-Position: refs/heads/master@{#302332}