Require confirmation for writable directory access.
commit819afb5cd5cb6384bde9c9d6b255eaef186426c2
authorsammc@chromium.org <sammc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 6 Sep 2013 07:21:30 +0000 (6 07:21 +0000)
committersammc@chromium.org <sammc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 6 Sep 2013 07:21:30 +0000 (6 07:21 +0000)
treef1ab1e7e4375f07013a8f7fc42774f89f8499af2
parent5556c5d23047abd3a19705103a1ec14b1026d92e
Require confirmation for writable directory access.

Previously, an app could request just the fileSystem.write permission,
followed by just the fileSystem.directory permission. This would prompt
the user to allow write access to files and read-only access to
directories, respectively. If the app were to later request both at the
same time, this would allow write access to directories without further
user confirmation.

This change adds an implicit fileSystem.writeDirectory if both
fileSystem.write and fileSystem.directory are requested at the same
time. This requires the user to confirm write access to directories.

BUG=148486

Review URL: https://chromiumcodereview.appspot.com/23506021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221620 0039d316-1c4b-4281-b951-d872f2087c98
chrome/common/extensions/permissions/api_permission.h
chrome/common/extensions/permissions/api_permission_set.cc
chrome/common/extensions/permissions/api_permission_set.h
chrome/common/extensions/permissions/api_permission_set_unittest.cc
chrome/common/extensions/permissions/chrome_api_permissions.cc
chrome/common/extensions/permissions/permission_set.cc
chrome/common/extensions/permissions/permission_set_unittest.cc
chrome/common/extensions/permissions/permissions_data.cc