Refactor the API for CertVerifier::Verify() and the implementation of MultiThreadedCe...
commit7f9236a3b9a7c0f7eb1d231c65027d0c4c535f3c
authoreroman <eroman@chromium.org>
Mon, 11 May 2015 21:23:43 +0000 (11 14:23 -0700)
committerCommit bot <commit-bot@chromium.org>
Mon, 11 May 2015 21:24:02 +0000 (11 21:24 +0000)
tree433a9c8e77c5f9833aeaf4e135b1a52b04e456d7
parent10018b2d2d5954cb697ccad19eef63919aef0786
Refactor the API for CertVerifier::Verify() and the implementation of MultiThreadedCertVerifier::Verify().

* CertVerifier::Verify() fills a |scoped_pointer<Request>*| rather than a |void*|

* CertVerifier::CancelRequest(void*) has been removed. Requests are instead cancelled by resetting the scoped_ptr<Request>.

* Refactored memory ownership in MultiThreadedCertVerifier so there are no manual calls to "delete".

* Removed locking and the CertVerifierWorker in favor of using WorkerPool::PostTaskAndReply()

BUG=475153,479336
TBR=pneubeck@chromium.org,zea@chromium.org,sergeyu@chromium.org

Review URL: https://codereview.chromium.org/1115903002

Cr-Commit-Position: refs/heads/master@{#329234}
20 files changed:
chrome/browser/chromeos/policy/policy_cert_verifier.cc
chrome/browser/chromeos/policy/policy_cert_verifier.h
chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc
google_apis/gcm/tools/mcs_probe.cc
net/cert/cert_verifier.h
net/cert/mock_cert_verifier.cc
net/cert/mock_cert_verifier.h
net/cert/multi_threaded_cert_verifier.cc
net/cert/multi_threaded_cert_verifier.h
net/cert/multi_threaded_cert_verifier_unittest.cc
net/cert/single_request_cert_verifier.cc [deleted file]
net/cert/single_request_cert_verifier.h [deleted file]
net/cert_net/nss_ocsp_unittest.cc
net/net.gypi
net/quic/crypto/proof_verifier_chromium.cc
net/socket/ssl_client_socket_nss.cc
net/socket/ssl_client_socket_nss.h
net/socket/ssl_client_socket_openssl.cc
net/socket/ssl_client_socket_openssl.h
remoting/protocol/ssl_hmac_channel_authenticator.cc