| commit | 7dd31c596f6e6277a263beb9268ef92238e30a85 | |
| author | pauljensen <pauljensen@chromium.org> | |
| Tue, 15 Sep 2015 11:15:37 +0000 (15 04:15 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 15 Sep 2015 11:16:23 +0000 (15 11:16 +0000) | ||
| tree | f5aad46722ac7650b547ed0c0080c7df03913919 | treesnapshot (tar.gz zip) |
| parent | ffae9cde39b5569caa4c7939a0818f7aa3ec471b | commitdiff |
[Cronet] Add read() replacement that modifies ByteBuffer position() not limit()
This is more in line with other Java APIs (e.g. ReadableByteChannel.read).
Replacing read() directly would be break API compatibility, so this CL adds
a new API, readNew(), to transition embedders to until read() is removed and
readNew() is renamed read() in later CLs. Also included in this CL are some
non-functional changes to use ByteBuffer limit() rather than capacity() when
appropriate.
BUG=531538
Review URL: https://codereview.chromium.org/1322203004
Cr-Commit-Position: refs/heads/master@{#348868}
This is more in line with other Java APIs (e.g. ReadableByteChannel.read).
Replacing read() directly would be break API compatibility, so this CL adds
a new API, readNew(), to transition embedders to until read() is removed and
readNew() is renamed read() in later CLs. Also included in this CL are some
non-functional changes to use ByteBuffer limit() rather than capacity() when
appropriate.
BUG=531538
Review URL: https://codereview.chromium.org/1322203004
Cr-Commit-Position: refs/heads/master@{#348868}